Skip to content

WebGPURenderer: Allow manual mipmap creation with StorageTexture #31983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 7, 2025
Merged

WebGPURenderer: Allow manual mipmap creation with StorageTexture #31983

merged 4 commits into from
Oct 7, 2025
+55 −7

Conversation

RenaudRohlinger
Copy link
Collaborator

@RenaudRohlinger RenaudRohlinger commented Sep 30, 2025 •
edited
Loading

Description

Allow handling manually mipmap of StorageTexture and writing to specific mipLevel via compute:

const storageTexture = new THREE.StorageTexture( width, height );
storageTexture.generateMipmaps = true;
storageTexture.mipmapsAutoUpdate = false;
...
const createComputeTexture = ( mipLevel ) => Fn( ( { storageTexture, mipLevelIndex, mipWidth } ) => {
textureStore( storageTexture, indexUV, outputColor ).setMipLevel( mipLevel ).toWriteOnly();
})

This contribution is funded by Utsubo

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2025 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 338.24
79.14		 338.24
79.14		 +0 B
+0 B
WebGPU 589.9
162.96		 590.25
163.06		 +348 B
+100 B
WebGPU Nodes 588.51
162.72		 588.86
162.81		 +348 B
+99 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 469.7
113.74		 469.7
113.74		 +0 B
+0 B
WebGPU 659.22
178.36		 659.42
178.42		 +199 B
+57 B
WebGPU Nodes 613.23
167.54		 613.43
167.6		 +199 B
+58 B

@Mugen87 Mugen87 added this to the r182 milestone Sep 30, 2025
@Makio64
Copy link
Contributor

Makio64 commented Sep 30, 2025

@RenaudRohlinger instead of manualMipmaps maybe computedMipmaps is more explicit ?

@RenaudRohlinger
Copy link
Collaborator Author

I think computed feels too specific, I like manualMipmaps for the concept of handling manually the mipmaps. But I get your point!

@sunag
Copy link
Collaborator

sunag commented Oct 1, 2025 •
edited
Loading

I think we could use mipmapsAutoUpdate, that would be more in line with matrixAutoUpdate. Normally, automatic processes are the properties assigned as true as default.

@RenaudRohlinger
Copy link
Collaborator Author

Updated the PR accordingly to your feedbacks @sunag! Now using mipmapsAutoUpdate = false.

@RenaudRohlinger
Copy link
Collaborator Author

Any reason why r182 for this one @Mugen87 😄?

@Mugen87
Copy link
Collaborator

Mugen87 commented Oct 4, 2025

I've thought the release is soon and for stability reasons I'd like to avoid changes to the core which are not bug fixes.

@Mugen87 Mugen87 modified the milestones: r182, r181 Oct 7, 2025
@Mugen87
Copy link
Collaborator

Mugen87 commented Oct 7, 2025 •
edited
Loading

It seems r181 will be released a bit later, see #32022 (comment). Before blocking devfor too long let's merge the PR.

@Mugen87 Mugen87 merged commit e180974 into mrdoob:dev Oct 7, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r181
Development

Successfully merging this pull request may close these issues.
4 participants
@RenaudRohlinger @Makio64 @sunag @Mugen87